0x90/Marlin
12
0
Fork 0
Code Issues Pull requests Packages Projects Releases Wiki Activity

Miscellaneous cleanup

Browse source
This commit is contained in:
Scott Lahteine 2017-11-16 00:27:24 -06:00
parent 63257dc083
commit 50f09cc029
4 changed files with 24 additions and 38 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

45
Marlin/src/feature/Max7219_Debug_LEDs.cpp
View file

@ -63,54 +63,41 @@
static uint8_t LEDs[8] = { 0 }; static uint8_t LEDs[8] = { 0 };
#ifdef CPU_32_BIT
#define MS_DELAY() delayMicroseconds(5) // 32-bit processors need a delay to stabilize the signal
#else
#define MS_DELAY() NOOP
#endif
void Max7219_PutByte(uint8_t data) { void Max7219_PutByte(uint8_t data) {
CRITICAL_SECTION_START CRITICAL_SECTION_START
for (uint8_t i = 8; i--;) { for (uint8_t i = 8; i--;) {
#ifdef CPU_32_BIT // The 32-bit processors are so fast, a small delay in the code is needed MS_DELAY();
delayMicroseconds(5); // to let the signal wires stabilize.
WRITE(MAX7219_CLK_PIN, LOW); // tick WRITE(MAX7219_CLK_PIN, LOW); // tick
delayMicroseconds(5); MS_DELAY();
WRITE(MAX7219_DIN_PIN, (data & 0x80) ? HIGH : LOW); // send 1 or 0 based on data bit WRITE(MAX7219_DIN_PIN, (data & 0x80) ? HIGH : LOW); // send 1 or 0 based on data bit
delayMicroseconds(5); MS_DELAY();
WRITE(MAX7219_CLK_PIN, HIGH); // tock WRITE(MAX7219_CLK_PIN, HIGH); // tock
delayMicroseconds(5); MS_DELAY();
#else
WRITE(MAX7219_CLK_PIN, LOW); // tick
WRITE(MAX7219_DIN_PIN, (data & 0x80) ? HIGH : LOW); // send 1 or 0 based on data bit
WRITE(MAX7219_CLK_PIN, HIGH); // tock
#endif
data <<= 1; data <<= 1;
} }
CRITICAL_SECTION_END CRITICAL_SECTION_END
} }
void Max7219(const uint8_t reg, const uint8_t data) { void Max7219(const uint8_t reg, const uint8_t data) {
#ifdef CPU_32_BIT MS_DELAY();
delayMicroseconds(5);
#endif
CRITICAL_SECTION_START CRITICAL_SECTION_START
WRITE(MAX7219_LOAD_PIN, LOW); // begin WRITE(MAX7219_LOAD_PIN, LOW); // begin
#ifdef CPU_32_BIT // The 32-bit processors are so fast, a small delay in the code is needed MS_DELAY();
delayMicroseconds(5); // to let the signal wires stabilize.
#endif
Max7219_PutByte(reg); // specify register Max7219_PutByte(reg); // specify register
#ifdef CPU_32_BIT MS_DELAY();
delayMicroseconds(5);
#endif
Max7219_PutByte(data); // put data Max7219_PutByte(data); // put data
#ifdef CPU_32_BIT MS_DELAY();
delayMicroseconds(5);
#endif
WRITE(MAX7219_LOAD_PIN, LOW); // and tell the chip to load the data WRITE(MAX7219_LOAD_PIN, LOW); // and tell the chip to load the data
#ifdef CPU_32_BIT MS_DELAY();
delayMicroseconds(5);
#endif
WRITE(MAX7219_LOAD_PIN, HIGH); WRITE(MAX7219_LOAD_PIN, HIGH);
CRITICAL_SECTION_END CRITICAL_SECTION_END
#ifdef CPU_32_BIT MS_DELAY();
delayMicroseconds(5);
#endif
} }
void Max7219_LED_Set(const uint8_t row, const uint8_t col, const bool on) { void Max7219_LED_Set(const uint8_t row, const uint8_t col, const bool on) {

4
Marlin/src/gcode/geometry/M206_M428.cpp
View file

@ -43,8 +43,8 @@ void GcodeSuite::M206() {
set_home_offset((AxisEnum)i, parser.value_linear_units()); set_home_offset((AxisEnum)i, parser.value_linear_units());
#if ENABLED(MORGAN_SCARA) #if ENABLED(MORGAN_SCARA)
if (parser.seen('T')) set_home_offset(A_AXIS, parser.value_linear_units()); // Theta if (parser.seen('T')) set_home_offset(A_AXIS, parser.value_float()); // Theta
if (parser.seen('P')) set_home_offset(B_AXIS, parser.value_linear_units()); // Psi if (parser.seen('P')) set_home_offset(B_AXIS, parser.value_float()); // Psi
#endif #endif
report_current_position(); report_current_position();

4
Marlin/src/gcode/motion/M290.cpp
View file

@ -36,14 +36,14 @@ void GcodeSuite::M290() {
#if ENABLED(BABYSTEP_XY) #if ENABLED(BABYSTEP_XY)
for (uint8_t a = X_AXIS; a <= Z_AXIS; a++) for (uint8_t a = X_AXIS; a <= Z_AXIS; a++)
if (parser.seenval(axis_codes[a]) || (a == Z_AXIS && parser.seenval('S'))) { if (parser.seenval(axis_codes[a]) || (a == Z_AXIS && parser.seenval('S'))) {
const float offs = constrain(parser.value_axis_units(a), -2, 2); const float offs = constrain(parser.value_axis_units((AxisEnum)a), -2, 2);
#if ENABLED(BABYSTEP_ZPROBE_OFFSET) #if ENABLED(BABYSTEP_ZPROBE_OFFSET)
if (a == Z_AXIS) { if (a == Z_AXIS) {
zprobe_zoffset += offs; zprobe_zoffset += offs;
refresh_zprobe_zoffset(true); // 'true' to not babystep refresh_zprobe_zoffset(true); // 'true' to not babystep
} }
#endif #endif
thermalManager.babystep_axis(a, offs * planner.axis_steps_per_mm[a]); thermalManager.babystep_axis((AxisEnum)a, offs * planner.axis_steps_per_mm[a]);
} }
#else #else
if (parser.seenval('Z') || parser.seenval('S')) { if (parser.seenval('Z') || parser.seenval('S')) {

3
Marlin/src/module/planner.cpp
View file

@ -542,8 +542,7 @@ void Planner::check_axes_activity() {
} }
inline float calculate_volumetric_multiplier(const float &diameter) { inline float calculate_volumetric_multiplier(const float &diameter) {
if (!parser.volumetric_enabled || diameter == 0) return 1.0; return (parser.volumetric_enabled && diameter) ? 1.0 / CIRCLE_AREA(diameter * 0.5) : 1.0;
return 1.0 / CIRCLE_AREA(diameter * 0.5);
} }
void Planner::calculate_volumetric_multipliers() { void Planner::calculate_volumetric_multipliers() {