From 6131c624992188b310ffb8f871e31607ec0e620f Mon Sep 17 00:00:00 2001 From: Scott Lahteine Date: Wed, 12 Apr 2017 00:08:24 -0500 Subject: [PATCH] General cleanup --- Marlin/Marlin_main.cpp | 4 ---- Marlin/servo.cpp | 28 ++++++++++++++-------------- Marlin/stepper.cpp | 2 +- 3 files changed, 15 insertions(+), 19 deletions(-) diff --git a/Marlin/Marlin_main.cpp b/Marlin/Marlin_main.cpp index 4f6b31a703..e9b57c69dc 100644 --- a/Marlin/Marlin_main.cpp +++ b/Marlin/Marlin_main.cpp @@ -5858,10 +5858,6 @@ inline void gcode_M42() { #else - #if !defined(z_servo_angle) - const int z_servo_angle[2] = Z_SERVO_ANGLES; - #endif - const uint8_t probe_index = code_seen('P') ? code_value_byte() : Z_ENDSTOP_SERVO_NR; SERIAL_PROTOCOLLNPGM("Servo probe test"); diff --git a/Marlin/servo.cpp b/Marlin/servo.cpp index 5be9441e44..bfe24c8b6d 100644 --- a/Marlin/servo.cpp +++ b/Marlin/servo.cpp @@ -168,8 +168,8 @@ static void initISR(timer16_Sequence_t timer) { SBI(TIFR, OCF3A); // clear any pending interrupts; SBI(ETIMSK, OCIE3A); // enable the output compare interrupt #else - TIFR3 = _BV(OCF3A); // clear any pending interrupts; - TIMSK3 = _BV(OCIE3A) ; // enable the output compare interrupt + SBI(TIFR3, OCF3A); // clear any pending interrupts; + SBI(TIMSK3, OCIE3A); // enable the output compare interrupt #endif #ifdef WIRING timerAttach(TIMER3OUTCOMPAREA_INT, Timer3Service); // for Wiring platform only @@ -183,7 +183,7 @@ static void initISR(timer16_Sequence_t timer) { TCCR4B = _BV(CS41); // set prescaler of 8 TCNT4 = 0; // clear the timer count TIFR4 = _BV(OCF4A); // clear any pending interrupts; - TIMSK4 = _BV(OCIE4A) ; // enable the output compare interrupt + TIMSK4 = _BV(OCIE4A); // enable the output compare interrupt } #endif @@ -193,7 +193,7 @@ static void initISR(timer16_Sequence_t timer) { TCCR5B = _BV(CS51); // set prescaler of 8 TCNT5 = 0; // clear the timer count TIFR5 = _BV(OCF5A); // clear any pending interrupts; - TIMSK5 = _BV(OCIE5A) ; // enable the output compare interrupt + TIMSK5 = _BV(OCIE5A); // enable the output compare interrupt } #endif } @@ -203,21 +203,21 @@ static void finISR(timer16_Sequence_t timer) { #ifdef WIRING if (timer == _timer1) { CBI( - #if defined(__AVR_ATmega1281__) || defined(__AVR_ATmega2561__) - TIMSK1 - #else - TIMSK - #endif + #if defined(__AVR_ATmega1281__) || defined(__AVR_ATmega2561__) + TIMSK1 + #else + TIMSK + #endif , OCIE1A); // disable timer 1 output compare interrupt timerDetach(TIMER1OUTCOMPAREA_INT); } else if (timer == _timer3) { CBI( - #if defined(__AVR_ATmega1281__) || defined(__AVR_ATmega2561__) - TIMSK3 - #else - ETIMSK - #endif + #if defined(__AVR_ATmega1281__) || defined(__AVR_ATmega2561__) + TIMSK3 + #else + ETIMSK + #endif , OCIE3A); // disable the timer3 output compare A interrupt timerDetach(TIMER3OUTCOMPAREA_INT); } diff --git a/Marlin/stepper.cpp b/Marlin/stepper.cpp index 11d20251f3..0ae6ee7a6f 100644 --- a/Marlin/stepper.cpp +++ b/Marlin/stepper.cpp @@ -271,7 +271,7 @@ volatile long Stepper::endstops_trigsteps[XYZ]; * The slope of acceleration is calculated using v = u + at where t is the accumulated timer values of the steps so far. */ void Stepper::wake_up() { - // TCNT1 = 0; + // TCNT1 = 0; ENABLE_STEPPER_DRIVER_INTERRUPT(); }