Abort SD printing more safely (#10407)

Allow the current command to complete when aborting an SD print, otherwise some commands (G28, G29, etc.) will cause trouble.
This commit is contained in:
Scott Lahteine 2018-04-15 18:27:54 -05:00 committed by GitHub
parent c9aed73987
commit 6c7a17dba6
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
3 changed files with 29 additions and 13 deletions

View file

@ -898,6 +898,26 @@ void loop() {
#endif #endif
for (;;) { for (;;) {
#if ENABLED(SDSUPPORT) && ENABLED(ULTIPANEL)
if (abort_sd_printing) {
abort_sd_printing = false;
card.stopSDPrint(
#if SD_RESORT
true
#endif
);
clear_command_queue();
quickstop_stepper();
print_job_timer.stop();
thermalManager.disable_all_heaters();
#if FAN_COUNT > 0
for (uint8_t i = 0; i < FAN_COUNT; i++) fanSpeeds[i] = 0;
#endif
wait_for_heatup = false;
}
#endif // SDSUPPORT && ULTIPANEL
if (commands_in_queue < BUFSIZE) get_available_commands(); if (commands_in_queue < BUFSIZE) get_available_commands();
advance_command_queue(); advance_command_queue();
endstops.report_state(); endstops.report_state();

View file

@ -836,20 +836,10 @@ void kill_screen(const char* lcd_msg) {
lcd_reset_status(); lcd_reset_status();
} }
bool abort_sd_printing; // =false
void lcd_sdcard_stop() { void lcd_sdcard_stop() {
card.stopSDPrint( abort_sd_printing = true;
#if SD_RESORT
true
#endif
);
clear_command_queue();
quickstop_stepper();
print_job_timer.stop();
thermalManager.disable_all_heaters();
#if FAN_COUNT > 0
for (uint8_t i = 0; i < FAN_COUNT; i++) fanSpeeds[i] = 0;
#endif
wait_for_heatup = false;
lcd_setstatusPGM(PSTR(MSG_PRINT_ABORTED), -1); lcd_setstatusPGM(PSTR(MSG_PRINT_ABORTED), -1);
lcd_return_to_status(); lcd_return_to_status();
} }

View file

@ -261,4 +261,10 @@ void lcd_reset_status();
void lcd_reselect_last_file(); void lcd_reselect_last_file();
#endif #endif
#if ENABLED(ULTIPANEL) && ENABLED(SDSUPPORT)
extern bool abort_sd_printing;
#else
constexpr bool abort_sd_printing = false;
#endif
#endif // ULTRALCD_H #endif // ULTRALCD_H