From f62f4006afa1cecd7b40cdcb264a72eb762830db Mon Sep 17 00:00:00 2001 From: Sebastianv650 Date: Mon, 28 Nov 2016 17:07:23 +0100 Subject: [PATCH] Account for LCD improvements in ENSURE_SMOOTH_MOVES .. and give the hint to try lower values if possible. --- Marlin/Configuration_adv.h | 3 ++- Marlin/example_configurations/Cartesio/Configuration_adv.h | 3 ++- Marlin/example_configurations/Felix/Configuration_adv.h | 3 ++- Marlin/example_configurations/Hephestos/Configuration_adv.h | 3 ++- Marlin/example_configurations/Hephestos_2/Configuration_adv.h | 3 ++- Marlin/example_configurations/K8200/Configuration_adv.h | 3 ++- Marlin/example_configurations/K8400/Configuration_adv.h | 3 ++- Marlin/example_configurations/RigidBot/Configuration_adv.h | 3 ++- Marlin/example_configurations/SCARA/Configuration_adv.h | 3 ++- Marlin/example_configurations/TAZ4/Configuration_adv.h | 3 ++- Marlin/example_configurations/WITBOX/Configuration_adv.h | 3 ++- Marlin/example_configurations/delta/biv2.5/Configuration_adv.h | 3 ++- .../example_configurations/delta/generic/Configuration_adv.h | 3 ++- .../delta/kossel_mini/Configuration_adv.h | 3 ++- .../delta/kossel_pro/Configuration_adv.h | 3 ++- .../example_configurations/delta/kossel_xl/Configuration_adv.h | 3 ++- Marlin/example_configurations/makibox/Configuration_adv.h | 3 ++- .../example_configurations/tvrrug/Round2/Configuration_adv.h | 3 ++- 18 files changed, 36 insertions(+), 18 deletions(-) diff --git a/Marlin/Configuration_adv.h b/Marlin/Configuration_adv.h index 2538128d3b..4c727f57e0 100644 --- a/Marlin/Configuration_adv.h +++ b/Marlin/Configuration_adv.h @@ -525,8 +525,9 @@ #if ENABLED(ENSURE_SMOOTH_MOVES) //#define ALWAYS_ALLOW_MENU // If enabled, the menu will always be responsive. // WARNING: Menu navigation during short moves may cause stuttering! - #define LCD_UPDATE_THRESHOLD 170 // (ms) Minimum duration for the current segment to allow an LCD update. + #define LCD_UPDATE_THRESHOLD 135 // (ms) Minimum duration for the current segment to allow an LCD update. // Default value is good for graphical LCDs (e.g., REPRAP_DISCOUNT_FULL_GRAPHIC_SMART_CONTROLLER). + // You may try to lower this value until you printer starts stuttering again as if ENSURE_SMOOTH_MOVES is disabled. #define MIN_BLOCK_TIME 6 // (ms) Minimum duration of a single block. You shouldn't need to modify this. #endif diff --git a/Marlin/example_configurations/Cartesio/Configuration_adv.h b/Marlin/example_configurations/Cartesio/Configuration_adv.h index 5aede9304a..623a29bdc6 100644 --- a/Marlin/example_configurations/Cartesio/Configuration_adv.h +++ b/Marlin/example_configurations/Cartesio/Configuration_adv.h @@ -525,8 +525,9 @@ #if ENABLED(ENSURE_SMOOTH_MOVES) //#define ALWAYS_ALLOW_MENU // If enabled, the menu will always be responsive. // WARNING: Menu navigation during short moves may cause stuttering! - #define LCD_UPDATE_THRESHOLD 170 // (ms) Minimum duration for the current segment to allow an LCD update. + #define LCD_UPDATE_THRESHOLD 135 // (ms) Minimum duration for the current segment to allow an LCD update. // Default value is good for graphical LCDs (e.g., REPRAP_DISCOUNT_FULL_GRAPHIC_SMART_CONTROLLER). + // You may try to lower this value until you printer starts stuttering again as if ENSURE_SMOOTH_MOVES is disabled. #define MIN_BLOCK_TIME 6 // (ms) Minimum duration of a single block. You shouldn't need to modify this. #endif diff --git a/Marlin/example_configurations/Felix/Configuration_adv.h b/Marlin/example_configurations/Felix/Configuration_adv.h index 90076a1fff..78b25213bc 100644 --- a/Marlin/example_configurations/Felix/Configuration_adv.h +++ b/Marlin/example_configurations/Felix/Configuration_adv.h @@ -525,8 +525,9 @@ #if ENABLED(ENSURE_SMOOTH_MOVES) //#define ALWAYS_ALLOW_MENU // If enabled, the menu will always be responsive. // WARNING: Menu navigation during short moves may cause stuttering! - #define LCD_UPDATE_THRESHOLD 170 // (ms) Minimum duration for the current segment to allow an LCD update. + #define LCD_UPDATE_THRESHOLD 135 // (ms) Minimum duration for the current segment to allow an LCD update. // Default value is good for graphical LCDs (e.g., REPRAP_DISCOUNT_FULL_GRAPHIC_SMART_CONTROLLER). + // You may try to lower this value until you printer starts stuttering again as if ENSURE_SMOOTH_MOVES is disabled. #define MIN_BLOCK_TIME 6 // (ms) Minimum duration of a single block. You shouldn't need to modify this. #endif diff --git a/Marlin/example_configurations/Hephestos/Configuration_adv.h b/Marlin/example_configurations/Hephestos/Configuration_adv.h index 79c5ab87f3..ca0a02393c 100644 --- a/Marlin/example_configurations/Hephestos/Configuration_adv.h +++ b/Marlin/example_configurations/Hephestos/Configuration_adv.h @@ -525,8 +525,9 @@ #if ENABLED(ENSURE_SMOOTH_MOVES) //#define ALWAYS_ALLOW_MENU // If enabled, the menu will always be responsive. // WARNING: Menu navigation during short moves may cause stuttering! - #define LCD_UPDATE_THRESHOLD 170 // (ms) Minimum duration for the current segment to allow an LCD update. + #define LCD_UPDATE_THRESHOLD 135 // (ms) Minimum duration for the current segment to allow an LCD update. // Default value is good for graphical LCDs (e.g., REPRAP_DISCOUNT_FULL_GRAPHIC_SMART_CONTROLLER). + // You may try to lower this value until you printer starts stuttering again as if ENSURE_SMOOTH_MOVES is disabled. #define MIN_BLOCK_TIME 6 // (ms) Minimum duration of a single block. You shouldn't need to modify this. #endif diff --git a/Marlin/example_configurations/Hephestos_2/Configuration_adv.h b/Marlin/example_configurations/Hephestos_2/Configuration_adv.h index ee2c63fcbb..ce8adc7a13 100644 --- a/Marlin/example_configurations/Hephestos_2/Configuration_adv.h +++ b/Marlin/example_configurations/Hephestos_2/Configuration_adv.h @@ -525,8 +525,9 @@ #if ENABLED(ENSURE_SMOOTH_MOVES) //#define ALWAYS_ALLOW_MENU // If enabled, the menu will always be responsive. // WARNING: Menu navigation during short moves may cause stuttering! - #define LCD_UPDATE_THRESHOLD 170 // (ms) Minimum duration for the current segment to allow an LCD update. + #define LCD_UPDATE_THRESHOLD 135 // (ms) Minimum duration for the current segment to allow an LCD update. // Default value is good for graphical LCDs (e.g., REPRAP_DISCOUNT_FULL_GRAPHIC_SMART_CONTROLLER). + // You may try to lower this value until you printer starts stuttering again as if ENSURE_SMOOTH_MOVES is disabled. #define MIN_BLOCK_TIME 6 // (ms) Minimum duration of a single block. You shouldn't need to modify this. #endif diff --git a/Marlin/example_configurations/K8200/Configuration_adv.h b/Marlin/example_configurations/K8200/Configuration_adv.h index 0cb7199be1..9bcb05e682 100644 --- a/Marlin/example_configurations/K8200/Configuration_adv.h +++ b/Marlin/example_configurations/K8200/Configuration_adv.h @@ -538,8 +538,9 @@ #if ENABLED(ENSURE_SMOOTH_MOVES) //#define ALWAYS_ALLOW_MENU // If enabled, the menu will always be responsive. // WARNING: Menu navigation during short moves may cause stuttering! - #define LCD_UPDATE_THRESHOLD 170 // (ms) Minimum duration for the current segment to allow an LCD update. + #define LCD_UPDATE_THRESHOLD 135 // (ms) Minimum duration for the current segment to allow an LCD update. // Default value is good for graphical LCDs (e.g., REPRAP_DISCOUNT_FULL_GRAPHIC_SMART_CONTROLLER). + // You may try to lower this value until you printer starts stuttering again as if ENSURE_SMOOTH_MOVES is disabled. #define MIN_BLOCK_TIME 6 // (ms) Minimum duration of a single block. You shouldn't need to modify this. #endif diff --git a/Marlin/example_configurations/K8400/Configuration_adv.h b/Marlin/example_configurations/K8400/Configuration_adv.h index d5be523ab0..fb308087c9 100644 --- a/Marlin/example_configurations/K8400/Configuration_adv.h +++ b/Marlin/example_configurations/K8400/Configuration_adv.h @@ -525,8 +525,9 @@ #if ENABLED(ENSURE_SMOOTH_MOVES) //#define ALWAYS_ALLOW_MENU // If enabled, the menu will always be responsive. // WARNING: Menu navigation during short moves may cause stuttering! - #define LCD_UPDATE_THRESHOLD 170 // (ms) Minimum duration for the current segment to allow an LCD update. + #define LCD_UPDATE_THRESHOLD 135 // (ms) Minimum duration for the current segment to allow an LCD update. // Default value is good for graphical LCDs (e.g., REPRAP_DISCOUNT_FULL_GRAPHIC_SMART_CONTROLLER). + // You may try to lower this value until you printer starts stuttering again as if ENSURE_SMOOTH_MOVES is disabled. #define MIN_BLOCK_TIME 6 // (ms) Minimum duration of a single block. You shouldn't need to modify this. #endif diff --git a/Marlin/example_configurations/RigidBot/Configuration_adv.h b/Marlin/example_configurations/RigidBot/Configuration_adv.h index c71179460b..a23d055990 100644 --- a/Marlin/example_configurations/RigidBot/Configuration_adv.h +++ b/Marlin/example_configurations/RigidBot/Configuration_adv.h @@ -525,8 +525,9 @@ #if ENABLED(ENSURE_SMOOTH_MOVES) //#define ALWAYS_ALLOW_MENU // If enabled, the menu will always be responsive. // WARNING: Menu navigation during short moves may cause stuttering! - #define LCD_UPDATE_THRESHOLD 170 // (ms) Minimum duration for the current segment to allow an LCD update. + #define LCD_UPDATE_THRESHOLD 135 // (ms) Minimum duration for the current segment to allow an LCD update. // Default value is good for graphical LCDs (e.g., REPRAP_DISCOUNT_FULL_GRAPHIC_SMART_CONTROLLER). + // You may try to lower this value until you printer starts stuttering again as if ENSURE_SMOOTH_MOVES is disabled. #define MIN_BLOCK_TIME 6 // (ms) Minimum duration of a single block. You shouldn't need to modify this. #endif diff --git a/Marlin/example_configurations/SCARA/Configuration_adv.h b/Marlin/example_configurations/SCARA/Configuration_adv.h index 63cc1bc4eb..92544293d7 100644 --- a/Marlin/example_configurations/SCARA/Configuration_adv.h +++ b/Marlin/example_configurations/SCARA/Configuration_adv.h @@ -525,8 +525,9 @@ #if ENABLED(ENSURE_SMOOTH_MOVES) //#define ALWAYS_ALLOW_MENU // If enabled, the menu will always be responsive. // WARNING: Menu navigation during short moves may cause stuttering! - #define LCD_UPDATE_THRESHOLD 170 // (ms) Minimum duration for the current segment to allow an LCD update. + #define LCD_UPDATE_THRESHOLD 135 // (ms) Minimum duration for the current segment to allow an LCD update. // Default value is good for graphical LCDs (e.g., REPRAP_DISCOUNT_FULL_GRAPHIC_SMART_CONTROLLER). + // You may try to lower this value until you printer starts stuttering again as if ENSURE_SMOOTH_MOVES is disabled. #define MIN_BLOCK_TIME 6 // (ms) Minimum duration of a single block. You shouldn't need to modify this. #endif diff --git a/Marlin/example_configurations/TAZ4/Configuration_adv.h b/Marlin/example_configurations/TAZ4/Configuration_adv.h index 3163bebeab..586e86d1b3 100644 --- a/Marlin/example_configurations/TAZ4/Configuration_adv.h +++ b/Marlin/example_configurations/TAZ4/Configuration_adv.h @@ -533,8 +533,9 @@ #if ENABLED(ENSURE_SMOOTH_MOVES) //#define ALWAYS_ALLOW_MENU // If enabled, the menu will always be responsive. // WARNING: Menu navigation during short moves may cause stuttering! - #define LCD_UPDATE_THRESHOLD 170 // (ms) Minimum duration for the current segment to allow an LCD update. + #define LCD_UPDATE_THRESHOLD 135 // (ms) Minimum duration for the current segment to allow an LCD update. // Default value is good for graphical LCDs (e.g., REPRAP_DISCOUNT_FULL_GRAPHIC_SMART_CONTROLLER). + // You may try to lower this value until you printer starts stuttering again as if ENSURE_SMOOTH_MOVES is disabled. #define MIN_BLOCK_TIME 6 // (ms) Minimum duration of a single block. You shouldn't need to modify this. #endif diff --git a/Marlin/example_configurations/WITBOX/Configuration_adv.h b/Marlin/example_configurations/WITBOX/Configuration_adv.h index c04fe92026..3a83f72a45 100644 --- a/Marlin/example_configurations/WITBOX/Configuration_adv.h +++ b/Marlin/example_configurations/WITBOX/Configuration_adv.h @@ -525,8 +525,9 @@ #if ENABLED(ENSURE_SMOOTH_MOVES) //#define ALWAYS_ALLOW_MENU // If enabled, the menu will always be responsive. // WARNING: Menu navigation during short moves may cause stuttering! - #define LCD_UPDATE_THRESHOLD 170 // (ms) Minimum duration for the current segment to allow an LCD update. + #define LCD_UPDATE_THRESHOLD 135 // (ms) Minimum duration for the current segment to allow an LCD update. // Default value is good for graphical LCDs (e.g., REPRAP_DISCOUNT_FULL_GRAPHIC_SMART_CONTROLLER). + // You may try to lower this value until you printer starts stuttering again as if ENSURE_SMOOTH_MOVES is disabled. #define MIN_BLOCK_TIME 6 // (ms) Minimum duration of a single block. You shouldn't need to modify this. #endif diff --git a/Marlin/example_configurations/delta/biv2.5/Configuration_adv.h b/Marlin/example_configurations/delta/biv2.5/Configuration_adv.h index 1617cbb68b..73569d29e2 100644 --- a/Marlin/example_configurations/delta/biv2.5/Configuration_adv.h +++ b/Marlin/example_configurations/delta/biv2.5/Configuration_adv.h @@ -527,8 +527,9 @@ #if ENABLED(ENSURE_SMOOTH_MOVES) //#define ALWAYS_ALLOW_MENU // If enabled, the menu will always be responsive. // WARNING: Menu navigation during short moves may cause stuttering! - #define LCD_UPDATE_THRESHOLD 170 // (ms) Minimum duration for the current segment to allow an LCD update. + #define LCD_UPDATE_THRESHOLD 135 // (ms) Minimum duration for the current segment to allow an LCD update. // Default value is good for graphical LCDs (e.g., REPRAP_DISCOUNT_FULL_GRAPHIC_SMART_CONTROLLER). + // You may try to lower this value until you printer starts stuttering again as if ENSURE_SMOOTH_MOVES is disabled. #define MIN_BLOCK_TIME 6 // (ms) Minimum duration of a single block. You shouldn't need to modify this. #endif diff --git a/Marlin/example_configurations/delta/generic/Configuration_adv.h b/Marlin/example_configurations/delta/generic/Configuration_adv.h index 0cc37d5919..fc38787020 100644 --- a/Marlin/example_configurations/delta/generic/Configuration_adv.h +++ b/Marlin/example_configurations/delta/generic/Configuration_adv.h @@ -527,8 +527,9 @@ #if ENABLED(ENSURE_SMOOTH_MOVES) //#define ALWAYS_ALLOW_MENU // If enabled, the menu will always be responsive. // WARNING: Menu navigation during short moves may cause stuttering! - #define LCD_UPDATE_THRESHOLD 170 // (ms) Minimum duration for the current segment to allow an LCD update. + #define LCD_UPDATE_THRESHOLD 135 // (ms) Minimum duration for the current segment to allow an LCD update. // Default value is good for graphical LCDs (e.g., REPRAP_DISCOUNT_FULL_GRAPHIC_SMART_CONTROLLER). + // You may try to lower this value until you printer starts stuttering again as if ENSURE_SMOOTH_MOVES is disabled. #define MIN_BLOCK_TIME 6 // (ms) Minimum duration of a single block. You shouldn't need to modify this. #endif diff --git a/Marlin/example_configurations/delta/kossel_mini/Configuration_adv.h b/Marlin/example_configurations/delta/kossel_mini/Configuration_adv.h index 0cc37d5919..fc38787020 100644 --- a/Marlin/example_configurations/delta/kossel_mini/Configuration_adv.h +++ b/Marlin/example_configurations/delta/kossel_mini/Configuration_adv.h @@ -527,8 +527,9 @@ #if ENABLED(ENSURE_SMOOTH_MOVES) //#define ALWAYS_ALLOW_MENU // If enabled, the menu will always be responsive. // WARNING: Menu navigation during short moves may cause stuttering! - #define LCD_UPDATE_THRESHOLD 170 // (ms) Minimum duration for the current segment to allow an LCD update. + #define LCD_UPDATE_THRESHOLD 135 // (ms) Minimum duration for the current segment to allow an LCD update. // Default value is good for graphical LCDs (e.g., REPRAP_DISCOUNT_FULL_GRAPHIC_SMART_CONTROLLER). + // You may try to lower this value until you printer starts stuttering again as if ENSURE_SMOOTH_MOVES is disabled. #define MIN_BLOCK_TIME 6 // (ms) Minimum duration of a single block. You shouldn't need to modify this. #endif diff --git a/Marlin/example_configurations/delta/kossel_pro/Configuration_adv.h b/Marlin/example_configurations/delta/kossel_pro/Configuration_adv.h index 14cf0fa5ff..421d4a4346 100644 --- a/Marlin/example_configurations/delta/kossel_pro/Configuration_adv.h +++ b/Marlin/example_configurations/delta/kossel_pro/Configuration_adv.h @@ -532,8 +532,9 @@ #if ENABLED(ENSURE_SMOOTH_MOVES) //#define ALWAYS_ALLOW_MENU // If enabled, the menu will always be responsive. // WARNING: Menu navigation during short moves may cause stuttering! - #define LCD_UPDATE_THRESHOLD 170 // (ms) Minimum duration for the current segment to allow an LCD update. + #define LCD_UPDATE_THRESHOLD 135 // (ms) Minimum duration for the current segment to allow an LCD update. // Default value is good for graphical LCDs (e.g., REPRAP_DISCOUNT_FULL_GRAPHIC_SMART_CONTROLLER). + // You may try to lower this value until you printer starts stuttering again as if ENSURE_SMOOTH_MOVES is disabled. #define MIN_BLOCK_TIME 6 // (ms) Minimum duration of a single block. You shouldn't need to modify this. #endif diff --git a/Marlin/example_configurations/delta/kossel_xl/Configuration_adv.h b/Marlin/example_configurations/delta/kossel_xl/Configuration_adv.h index 45d077bf95..35ef709493 100644 --- a/Marlin/example_configurations/delta/kossel_xl/Configuration_adv.h +++ b/Marlin/example_configurations/delta/kossel_xl/Configuration_adv.h @@ -527,8 +527,9 @@ #if ENABLED(ENSURE_SMOOTH_MOVES) //#define ALWAYS_ALLOW_MENU // If enabled, the menu will always be responsive. // WARNING: Menu navigation during short moves may cause stuttering! - #define LCD_UPDATE_THRESHOLD 170 // (ms) Minimum duration for the current segment to allow an LCD update. + #define LCD_UPDATE_THRESHOLD 135 // (ms) Minimum duration for the current segment to allow an LCD update. // Default value is good for graphical LCDs (e.g., REPRAP_DISCOUNT_FULL_GRAPHIC_SMART_CONTROLLER). + // You may try to lower this value until you printer starts stuttering again as if ENSURE_SMOOTH_MOVES is disabled. #define MIN_BLOCK_TIME 6 // (ms) Minimum duration of a single block. You shouldn't need to modify this. #endif diff --git a/Marlin/example_configurations/makibox/Configuration_adv.h b/Marlin/example_configurations/makibox/Configuration_adv.h index cf3a926261..7c6045b59e 100644 --- a/Marlin/example_configurations/makibox/Configuration_adv.h +++ b/Marlin/example_configurations/makibox/Configuration_adv.h @@ -525,8 +525,9 @@ #if ENABLED(ENSURE_SMOOTH_MOVES) //#define ALWAYS_ALLOW_MENU // If enabled, the menu will always be responsive. // WARNING: Menu navigation during short moves may cause stuttering! - #define LCD_UPDATE_THRESHOLD 170 // (ms) Minimum duration for the current segment to allow an LCD update. + #define LCD_UPDATE_THRESHOLD 135 // (ms) Minimum duration for the current segment to allow an LCD update. // Default value is good for graphical LCDs (e.g., REPRAP_DISCOUNT_FULL_GRAPHIC_SMART_CONTROLLER). + // You may try to lower this value until you printer starts stuttering again as if ENSURE_SMOOTH_MOVES is disabled. #define MIN_BLOCK_TIME 6 // (ms) Minimum duration of a single block. You shouldn't need to modify this. #endif diff --git a/Marlin/example_configurations/tvrrug/Round2/Configuration_adv.h b/Marlin/example_configurations/tvrrug/Round2/Configuration_adv.h index 312f4bdab5..006954135a 100644 --- a/Marlin/example_configurations/tvrrug/Round2/Configuration_adv.h +++ b/Marlin/example_configurations/tvrrug/Round2/Configuration_adv.h @@ -525,8 +525,9 @@ #if ENABLED(ENSURE_SMOOTH_MOVES) //#define ALWAYS_ALLOW_MENU // If enabled, the menu will always be responsive. // WARNING: Menu navigation during short moves may cause stuttering! - #define LCD_UPDATE_THRESHOLD 170 // (ms) Minimum duration for the current segment to allow an LCD update. + #define LCD_UPDATE_THRESHOLD 135 // (ms) Minimum duration for the current segment to allow an LCD update. // Default value is good for graphical LCDs (e.g., REPRAP_DISCOUNT_FULL_GRAPHIC_SMART_CONTROLLER). + // You may try to lower this value until you printer starts stuttering again as if ENSURE_SMOOTH_MOVES is disabled. #define MIN_BLOCK_TIME 6 // (ms) Minimum duration of a single block. You shouldn't need to modify this. #endif