check if account already exists to avoid double use of confirmation mail #72
Labels
No labels
bug
enhancement
good first issue
halted
help wanted
security
wait for upstream
wait to be tested
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference: b3yond/ticketfrei#72
Loading…
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Author: @b3yond Posted at: 11.01.2019 11:41
fixes #37, tested:
Test case 1
Steps to Reproduce:
Expected Behavior:
The first confirmation link redirects to the settings page, the second time to click on the link redirects to index with the error message "account already exists."
Actual Behavior:
The first confirmation link redirects to the settings page, the second time to click on the link redirects to index with the error message "account already exists."
Author: @b3yond Posted at: 11.01.2019 12:24
I also did a small refactor. What do you think about that 2nd change?
No big thing, the secret should not change anyway. But this way, we don't have it in the RAM and just get it from the DB the few times we need it, where it lays around anyway.
Author: @git-sid Posted at: 11.01.2019 12:29
doesn't break anything. Looking good
Author: @b3yond Posted at: 11.01.2019 12:32
it's just better code. It is losely related to the PR, because it's dependent on the secret keeping whether the confirmation link works or not.
it does not really change anything, because we don't have a function which changes the secret during runtime. We don't have any function touching the secret at all.