check if account already exists to avoid double use of confirmation mail #72

New Issue

Closed

opened 2019-06-10 09:49:33 +00:00 by b3yond · 3 comments

b3yond commented

2019-06-10 09:49:33 +00:00

Owner

Author: @b3yond Posted at: 11.01.2019 11:41

fixes #37, tested:

Test case 1

Steps to Reproduce:

register account
click on confirmation link once
click on confirmation link a second time

Expected Behavior:

The first confirmation link redirects to the settings page, the second time to click on the link redirects to index with the error message "account already exists."

Actual Behavior:

The first confirmation link redirects to the settings page, the second time to click on the link redirects to index with the error message "account already exists."

Author: @b3yond Posted at: 11.01.2019 11:41 fixes #37, tested: ## Test case 1 ### Steps to Reproduce: 1. register account 2. click on confirmation link once 3. click on confirmation link a second time ### Expected Behavior: The first confirmation link redirects to the settings page, the second time to click on the link redirects to index with the error message "account already exists." ### Actual Behavior: The first confirmation link redirects to the settings page, the second time to click on the link redirects to index with the error message "account already exists."

b3yond closed this issue

2019-06-10 09:49:33 +00:00

b3yond commented

2019-06-10 09:49:34 +00:00

Poster

Owner

Author: @b3yond Posted at: 11.01.2019 12:24

I also did a small refactor. What do you think about that 2nd change?

No big thing, the secret should not change anyway. But this way, we don't have it in the RAM and just get it from the DB the few times we need it, where it lays around anyway.

Author: @b3yond Posted at: 11.01.2019 12:24 I also did a small refactor. What do you think about that 2nd change? No big thing, the secret should not change anyway. But this way, we don't have it in the RAM and just get it from the DB the few times we need it, where it lays around anyway.

b3yond commented

2019-06-10 09:49:34 +00:00

Poster

Owner

Author: @git-sid Posted at: 11.01.2019 12:29

doesn't break anything. Looking good

Author: @git-sid Posted at: 11.01.2019 12:29 doesn't break anything. Looking good

b3yond commented

2019-06-10 09:49:34 +00:00

Poster

Owner

Author: @b3yond Posted at: 11.01.2019 12:32

it's just better code. It is losely related to the PR, because it's dependent on the secret keeping whether the confirmation link works or not.

it does not really change anything, because we don't have a function which changes the secret during runtime. We don't have any function touching the secret at all.

Author: @b3yond Posted at: 11.01.2019 12:32 it's just better code. It is losely related to the PR, because it's dependent on the secret keeping whether the confirmation link works or not. it does not really change anything, because we don't have a function which changes the secret during runtime. We don't have any function touching the secret at all.