b3yond/ticketfrei

Fork 0

Support reports with images #90

New issue

Open

opened 2019-06-10 09:49:49 +00:00 by b3yond · 5 comments

b3yond commented

2019-06-10 09:49:49 +00:00

Owner

Author: @b3yond Posted at: 06.04.2019 14:23

Problem

If you want to send images with one of the different platforms, it usually just throws an error or doesn't repost the image without error.

Additional context

A problem is that all platforms treat images differently. Telegram e.g. can only send images without text (the desktop client at least, I think?).

Solutions

We could add "image" as an extra attribute to report objects. But we don't even know whether all libraries treat images the same or whether we have to bring them to a standard format for this.

Other ideas?

Author: @b3yond Posted at: 06.04.2019 14:23 ## Problem If you want to send images with one of the different platforms, it usually just throws an error or doesn't repost the image without error. ### Additional context A problem is that all platforms treat images differently. Telegram e.g. can only send images without text (the desktop client at least, I think?). ## Solutions We could add "image" as an extra attribute to report objects. But we don't even know whether all libraries treat images the same or whether we have to bring them to a standard format for this. Other ideas?

b3yond added the

enhancement

label 2019-06-10 09:49:49 +00:00

b3yond commented

2019-06-10 09:49:50 +00:00

Author

Owner

Author: @b3yond Posted at: 03.05.2019 08:20

Images are a bad idea - personally I don't want faces of ticket controllers to be shared by the bot. It's a massive invasion into privacy - describing what clothes civil ticket controllers wear should be enough to protect fare dodgers.

So I favor the following approach:

If someone sends an image on telegram, reply with "Sorry, we don't support photos for privacy reasons. Can you write a report instead?"
- pressing issue, currently the bot crashes when someone posts an image.
If someone sends a photo on twitter, email, or mastodon, ignore it and just transfer the text.
*(this is the current behavior anyway.)

Author: @b3yond Posted at: 03.05.2019 08:20 Images are a bad idea - personally I don't want faces of ticket controllers to be shared by the bot. It's a massive invasion into privacy - describing what clothes civil ticket controllers wear should be enough to protect fare dodgers. So I favor the following approach: * If someone sends an image on telegram, reply with "Sorry, we don't support photos for privacy reasons. Can you write a report instead?" * pressing issue, currently the bot crashes when someone posts an image. * If someone sends a photo on twitter, email, or mastodon, ignore it and just transfer the text. *(this is the current behavior anyway.)

b3yond commented

2019-06-10 09:49:50 +00:00

Author

Owner

Author: @b3yond Posted at: 03.05.2019 09:54

Another good argument against supporting images: it's next to impossible to filter images for spam.

Author: @b3yond Posted at: 03.05.2019 09:54 Another good argument against supporting images: it's next to impossible to filter images for spam.

b3yond commented

2019-06-10 09:49:50 +00:00

Author

Owner

Author: @git-sid Posted at: 03.05.2019 12:58

Thanks for noting down my thoughts about this issue.
As such, I'm against image support.
I'd propose handling it this way:

If a report including a message is sent, check whether the report text itself is a valid report.
If it is, drop the image and share the text without a warning to the user.
If it is not a valid report, send a warning to the user.
This behavior could be combined with #88

Author: @git-sid Posted at: 03.05.2019 12:58 Thanks for noting down my thoughts about this issue. As such, I'm against image support. I'd propose handling it this way: If a report including a message is sent, check whether the report text itself is a valid report. If it is, drop the image and share the text without a warning to the user. If it is not a valid report, send a warning to the user. This behavior could be combined with #88

b3yond commented

2019-06-10 09:49:50 +00:00

Author

Owner

Author: @b3yond Posted at: 03.05.2019 14:05

A Telegram message can only be either an image or a text.

If #88 is only for Telegram (it could also be applied to email), then we can reply to photos that we don't support them, to valid reports with a "Thank you for your submission.", to reports which don't fit the trigger patterns "Are you sure that this is not spam? Maybe you spelled something wrong.", and for reports which fit the blocklist "Please be polite.".

I'll add a commit to #93

Author: @b3yond Posted at: 03.05.2019 14:05 A Telegram message can only be either an image or a text. If #88 is only for Telegram (it could also be applied to email), then we can reply to photos that we don't support them, to valid reports with a "Thank you for your submission.", to reports which don't fit the trigger patterns "Are you sure that this is not spam? Maybe you spelled something wrong.", and for reports which fit the blocklist "Please be polite.". I'll add a commit to #93

b3yond commented

2019-06-10 09:49:51 +00:00

Author

Owner

Author: @b3yond Posted at: 03.05.2019 14:26

Actually, #88 is leading to new problems. Let's discuss it there - for now I'm satisfied with #93. do you want to review it? Then we can merge and release a 2.1.3 patch release.

Author: @b3yond Posted at: 03.05.2019 14:26 Actually, #88 is leading to new problems. Let's discuss it there - for now I'm satisfied with #93. do you want to review it? Then we can merge and release a 2.1.3 patch release.