juergen/ticketfrei

Fork 0

FR: change background image for city page #29

New issue

Closed

opened 2019-06-10 09:41:26 +00:00 by b3yond · 9 comments

b3yond commented

2019-06-10 09:41:26 +00:00

Author: @b3yond Posted at: 17.07.2018 21:21

Some people apparently don't like our bg image :P :P

Author: @b3yond Posted at: 17.07.2018 21:21 Some people apparently don't like our bg image :P :P

b3yond added this to the Layout improvements milestone 2019-06-10 09:41:26 +00:00

b3yond added the

enhancement

label 2019-06-10 09:41:26 +00:00

b3yond closed this issue

2019-06-10 09:41:26 +00:00

b3yond commented

2019-06-10 09:41:26 +00:00

Author

Author: @b3yond Posted at: 06.10.2018 09:51

To be clear: we should make it possible in the settings to use a custom background image, not replace our wonderful background image.

Author: @b3yond Posted at: 06.10.2018 09:51 To be clear: we should make it possible in the settings to use a custom background image, not replace our wonderful background image.

b3yond commented

2019-06-10 09:41:27 +00:00

Author

Author: @git-sid Posted at: 18.10.2018 09:54

Our beautiful background image is indeed beautiful, but not as a cropped, tiled mess next to the city page.

Author: @git-sid Posted at: 18.10.2018 09:54 Our beautiful background image is indeed beautiful, but not as a cropped, tiled mess next to the city page.

b3yond commented

2019-06-10 09:41:27 +00:00

Author

Author: @git-sid Posted at: 30.10.2018 15:53

There are two options imo:

find a neutral wallpaper
randomize the wallpaper using something like unsplash

I'd prefer option 1. It's simple. But does a fitting image exist?
Option 2 circumvents this issue by loading a different image each refresh. There's more unnecessary overhead because of the loading of the image on every refresh. However, people couldn't argue that our bg image is ugly...

I'll propose to follow option 1 and try to find an fitting image.
Suggestions are always welcome.

Author: @git-sid Posted at: 30.10.2018 15:53 There are two options imo: 1. find a neutral wallpaper 2. randomize the wallpaper using something like [unsplash](https://unsplash.com/documentation#get-a-random-photo) I'd prefer option 1. It's simple. But does a fitting image exist? Option 2 circumvents this issue by loading a different image each refresh. There's more unnecessary overhead because of the loading of the image on every refresh. However, people couldn't argue that our bg image is ugly... I'll propose to follow option 1 and try to find an fitting image. Suggestions are always welcome.

b3yond commented

2019-06-10 09:41:27 +00:00

Author

Author: @b3yond Posted at: 01.11.2018 21:16

hrrrm. I changed the twitter header image of the nbg instance :P

Author: @b3yond Posted at: 01.11.2018 21:16 hrrrm. I changed the twitter header image of the nbg instance :P

b3yond commented

2019-06-10 09:41:27 +00:00

Author

Author: @b3yond Posted at: 01.11.2018 21:24

I still would go for having a default image and then making other bg images selectable.

We should also add an option to switch from having a tiled bg image to a stretched bg image.

Author: @b3yond Posted at: 01.11.2018 21:24 I still would go for having a default image and then making other bg images selectable. We should also add an option to switch from having a tiled bg image to a stretched bg image.

b3yond commented

2019-06-10 09:41:27 +00:00

Author

Author: @b3yond Posted at: 01.11.2018 21:32

Okay, we have decided to fork this repo and base our deployment on the forked repo, so we can apply changes. This repo will then have a more neutral background image, while our flagship instance and deployment practice be based on the new repo, where we will reenter the old and really beautiful image.

Author: @b3yond Posted at: 01.11.2018 21:32 Okay, we have decided to fork this repo and base our deployment on the forked repo, so we can apply changes. This repo will then have a more neutral background image, while our flagship instance and deployment practice be based on the new repo, where we will reenter the old and really beautiful image.

b3yond commented

2019-06-10 09:41:27 +00:00

Author

Author: @git-sid Posted at: 11.01.2019 12:45

Okay, we have decided to fork this repo and base our deployment on the forked repo, so we can apply changes. This repo will then have a more neutral background image, while our flagship instance and deployment practice be based on the new repo, where we will reenter the old and really beautiful image.

We should do this

Author: @git-sid Posted at: 11.01.2019 12:45 > Okay, we have decided to fork this repo and base our deployment on the forked repo, so we can apply changes. This repo will then have a more neutral background image, while our flagship instance and deployment practice be based on the new repo, where we will reenter the old and really beautiful image. We should do this

b3yond commented

2019-06-10 09:41:28 +00:00

Author

Author: @b3yond Posted at: 11.01.2019 14:13

do you have a proposal which image we could take? I suggest something dark to have a good contrast with the content div.

Author: @b3yond Posted at: 11.01.2019 14:13 do you have a proposal which image we could take? I suggest something dark to have a good contrast with the content div.

b3yond commented

2019-06-10 09:41:28 +00:00

Author

Author: @git-sid Posted at: 14.01.2019 09:26

fixed in 880b327

Author: @git-sid Posted at: 14.01.2019 09:26 fixed in 880b327