juergen/ticketfrei
1
0
Fork 0
Code Issues 15 Pull requests Releases Wiki Activity

Fuck the Twitter Rate Limit #45

New issue
Open
opened 2019-06-10 09:41:46 +00:00 by b3yond · 5 comments
b3yond commented 2019-06-10 09:41:46 +00:00
Copy link

Author: @b3yond Posted at: 06.10.2018 08:42

Right now, different modules use Twitter Rate Limiting:

  • twitterbot.py
  • twitterDM.py

the twitter rate limit counter is a global var in tfglobals. Each bot checks if there is space for the next request, when it's their turn. This could lead to one of the bots being skipped all the time.

Can someone think of a better solution?

Author: @b3yond Posted at: 06.10.2018 08:42 Right now, different modules use Twitter Rate Limiting: * twitterbot.py * twitterDM.py the twitter rate limit counter is a global var in tfglobals. Each bot checks if there is space for the next request, when it's their turn. This could lead to one of the bots being skipped all the time. Can someone think of a better solution?
b3yond commented 2019-06-10 09:41:47 +00:00
Author
Copy link

Author: @b3yond Posted at: 07.10.2018 19:55

We need to revert #39, this shit is unbearable.

Author: @b3yond Posted at: 07.10.2018 19:55 We need to revert #39, this shit is unbearable.
b3yond commented 2019-06-10 09:41:47 +00:00
Author
Copy link

Author: @b3yond Posted at: 07.10.2018 20:00

ah, according to https://blog.twitter.com/official/en_us/a/2008/what-does-rate-limit-exceeded-mean-updated.html the rate limit applies per account, not per app. #39 was very stupid.

Author: @b3yond Posted at: 07.10.2018 20:00 ah, according to https://blog.twitter.com/official/en_us/a/2008/what-does-rate-limit-exceeded-mean-updated.html the rate limit applies per account, not per app. #39 was very stupid.
b3yond commented 2019-06-10 09:41:47 +00:00
Author
Copy link

Author: @b3yond Posted at: 07.10.2018 20:01

Let's discuss all the twitter rate limit stuff in this issue.

Author: @b3yond Posted at: 07.10.2018 20:01 Let's discuss all the twitter rate limit stuff in this issue.
b3yond commented 2019-06-10 09:41:47 +00:00
Author
Copy link

Author: @b3yond Posted at: 07.10.2018 21:08

on production, I put a counter into twitterDMs, which should log each request, directly after checking the rate limit. there was not one request. this shit is still broken. twitter DMs don't work because of this.

Author: @b3yond Posted at: 07.10.2018 21:08 on production, I put a counter into twitterDMs, which should log each request, directly after checking the rate limit. there was not one request. this shit is still broken. twitter DMs don't work because of this.
b3yond commented 2019-06-10 09:41:48 +00:00
Author
Copy link

Author: @b3yond Posted at: 11.10.2018 20:28

okay, twitter DMs don't work for other reasons. (details: #39 )

So let's keep this issue open if other problems arise.

Author: @b3yond Posted at: 11.10.2018 20:28 okay, twitter DMs don't work for other reasons. (details: #39 ) So let's keep this issue open if other problems arise.
Sign in to join this conversation.
No Branch/Tag specified
Branches Tags
master
refactoring
stable2
stable3
feature/ping
coc
stable1
2.1.4
2.1.3
2.1.2
2.1.1
2.1.0
2.0.1
2.0.0
1.1
2.0.0beta
1.0
Labels
Clear labels   
bug

   
enhancement

   
good first issue

   
help wanted

   
security

   
wait for upstream

   
wait to be tested
No labels
bug
enhancement
good first issue
help wanted
security
wait for upstream
wait to be tested
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: juergen/ticketfrei#45
No description provided.
Delete branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?