Merge branch 'westnothnostats' into 'master'

Battle for Wesnoth - make stats submission OPTIN, remove antifeature

See merge request fdroid/fdroiddata!5246

metadata/it.alessandropira.wesnoth114.yml

@@ -1,5 +1,3 @@
-AntiFeatures:
-  - Tracking
 Categories:
   - Games
 License: GPL-2.0-or-later
@@ -18,10 +16,6 @@ Description: |-
     Or lead a straggly band of survivors across the blazing sands to confront an unseen
     evil.
 
-    Antifeatures: Tracking - "Send anonymous usage statistics" is enabled by default,
-    it connects to the Androids port developer owned server, it can be toggled off in
-    Settings->Startup Options.
-
 RepoType: git
 Repo: https://gitlab.com/f-droid-mirrors/empty
 
@@ -60,6 +54,8 @@ Builds:
         || exit//'
       - sed -i wesnoth/build.sh -e 's/ant debug || exit/ant release || exit/'
       - sed -i wesnoth/AndroidManifest.xml -e 's/android:debuggable="true"//'
+      - sed -i wesnoth/src/it/ap/wesnoth/Globals.java -e 's/sendStats = true;/sendStats
+        = false;/'
     output: wesnoth/bin/MainActivity-release-unsigned.apk
     target: android-26
     scandelete:
@@ -77,7 +73,8 @@ Builds:
       - ./build.sh
     ndk: r13b
 
-MaintainerNotes: Source code is located in the "files" section of SF in the form of
+MaintainerNotes: |-
+    Source code is located in the "files" section of SF in the form of
     tarballs. No VCS is used. The actual repo is a placeholder and not required at
     all (F-Droid buildserver still requires some repo, though). The source code is
     split into two parts, the library tarball and the game tarball. Each one is downloaded
@@ -90,6 +87,8 @@ MaintainerNotes: Source code is located in the "files" section of SF in the form
     The only prebuilt component in libraries tarball (that's used in building wesnoth)
     is openssl library, which we're building again.
 
+    Anonymous usage statistics submission is ON by default, we turn it OFF
+
 AutoUpdateMode: None
 UpdateCheckMode: None
 CurrentVersion: 1.14.5-53