From b1d01970372c997f966d38348e5ad8e45a426e1b Mon Sep 17 00:00:00 2001 From: Thomas Lindner Date: Tue, 7 Jul 2020 03:16:23 +0200 Subject: [PATCH] [tests] Add fixtures --- COPYING | 1 + kibicara/model.py | 5 ++ kibicara/webapi/admin.py | 6 +- tests/conftest.py | 107 ++++++++++++++++++++++++++++ tests/test_api_admin.py | 15 ++++ tests/test_api_hoods.py | 81 +++++++++++++++++++++ tests/test_api_test.py | 36 ++++++++++ tests/unit/test_api_hoods.py | 120 -------------------------------- tests/unit/test_api_register.py | 15 ---- 9 files changed, 249 insertions(+), 137 deletions(-) create mode 100644 tests/conftest.py create mode 100644 tests/test_api_admin.py create mode 100644 tests/test_api_hoods.py create mode 100644 tests/test_api_test.py delete mode 100644 tests/unit/test_api_hoods.py delete mode 100644 tests/unit/test_api_register.py diff --git a/COPYING b/COPYING index d593885..4b75eb5 100644 --- a/COPYING +++ b/COPYING @@ -1,5 +1,6 @@ Copyright (C) 2020 by Thomas Lindner Copyright (C) 2020 by Cathy Hu +Copyright (C) 2020 by Christian Permission to use, copy, modify, and/or distribute this software for any purpose with or without fee is hereby granted. diff --git a/kibicara/model.py b/kibicara/model.py index b324248..afe39ae 100644 --- a/kibicara/model.py +++ b/kibicara/model.py @@ -18,6 +18,11 @@ class Mapping: engine = create_engine(str(cls.database.url)) cls.metadata.create_all(engine) + @classmethod + def drop_all(cls): + engine = create_engine(str(cls.database.url)) + cls.metadata.drop_all(engine) + class Admin(Model): id: Integer(primary_key=True) = None diff --git a/kibicara/webapi/admin.py b/kibicara/webapi/admin.py index 731e2c6..b7eded2 100644 --- a/kibicara/webapi/admin.py +++ b/kibicara/webapi/admin.py @@ -16,6 +16,7 @@ from passlib.hash import argon2 from ormantic.exceptions import NoMatch from pickle import dumps, loads from pydantic import BaseModel +from smtplib import SMTPException from sqlite3 import IntegrityError @@ -71,7 +72,8 @@ router = APIRouter() @router.post('/register/', status_code=status.HTTP_202_ACCEPTED) async def admin_register(values: BodyAdmin): register_token = to_token(**values.__dict__) - logger.debug(register_token) + # this logging output is captured and used by the register_token test fixture + logger.info(register_token) try: send_email( to=values.email, @@ -79,7 +81,7 @@ async def admin_register(values: BodyAdmin): # XXX create real confirm link body=register_token, ) - except ConnectionRefusedError: + except (ConnectionRefusedError, SMTPException): logger.exception('Email sending failed') raise HTTPException(status_code=status.HTTP_502_BAD_GATEWAY) return {} diff --git a/tests/conftest.py b/tests/conftest.py new file mode 100644 index 0000000..51d9f56 --- /dev/null +++ b/tests/conftest.py @@ -0,0 +1,107 @@ +# Copyright (C) 2020 by Thomas Lindner +# +# SPDX-License-Identifier: 0BSD + +from fastapi import FastAPI, status +from fastapi.testclient import TestClient +from kibicara.model import Mapping +from kibicara.webapi import router +from logging import getLogger, Handler, INFO, WARNING +from pytest import fixture + + +@fixture(scope='module') +def client(): + Mapping.drop_all() + Mapping.create_all() + app = FastAPI() + app.include_router(router, prefix='/api') + return TestClient(app) + + +class CaptureHandler(Handler): + def __init__(self): + super().__init__() + self.records = [] + + def emit(self, record): + self.records.append(record) + + +@fixture(scope='module') +def register_token(client): + # can't use the caplog fixture, since it has only function scope + logger = getLogger() + capture = CaptureHandler() + logger.setLevel(INFO) + logger.addHandler(capture) + client.post('/api/admin/register/', json={'email': 'user', 'password': 'pass'}) + logger.setLevel(WARNING) + logger.removeHandler(capture) + return capture.records[0].message + + +@fixture(scope='module') +def register_confirmed(client, register_token): + response = client.post('/api/admin/confirm/%s' % register_token) + assert response.status_code == status.HTTP_200_OK + + +@fixture(scope='module') +def access_token(client, register_confirmed): + response = client.post( + '/api/admin/login/', data={'username': 'user', 'password': 'pass'} + ) + assert response.status_code == status.HTTP_200_OK + return response.json()['access_token'] + + +@fixture(scope='module') +def auth_header(access_token): + return {'Authorization': 'Bearer %s' % access_token} + + +@fixture(scope='function') +def hood_id(client, auth_header): + response = client.post('/api/hoods/', json={'name': 'hood'}, headers=auth_header) + assert response.status_code == status.HTTP_201_CREATED + hood_id = int(response.headers['Location']) + yield hood_id + client.delete('/api/hoods/%d' % hood_id, headers=auth_header) + + +@fixture(scope='function') +def trigger_id(client, hood_id, auth_header): + response = client.post( + '/api/hoods/%d/triggers/' % hood_id, json={'pattern': ''}, headers=auth_header + ) + assert response.status_code == status.HTTP_201_CREATED + trigger_id = int(response.headers['Location']) + yield trigger_id + client.delete( + '/api/hoods/%d/triggers/%d' % (hood_id, trigger_id), headers=auth_header + ) + + +@fixture(scope='function') +def badword_id(client, hood_id, auth_header): + response = client.post( + '/api/hoods/%d/badwords/' % hood_id, json={'pattern': ''}, headers=auth_header + ) + assert response.status_code == status.HTTP_201_CREATED + badword_id = int(response.headers['Location']) + yield badword_id + client.delete( + '/api/hoods/%d/badwords/%d' % (hood_id, badword_id), headers=auth_header + ) + + +@fixture(scope='function') +def test_id(client, hood_id, auth_header): + response = client.post( + '/api/hoods/%d/test/' % hood_id, json={}, headers=auth_header + ) + assert response.status_code == status.HTTP_201_CREATED + test_id = int(response.headers['Location']) + yield test_id + client.delete('/api/hoods/%d/test/%d' % (hood_id, test_id), headers=auth_header) diff --git a/tests/test_api_admin.py b/tests/test_api_admin.py new file mode 100644 index 0000000..148db6c --- /dev/null +++ b/tests/test_api_admin.py @@ -0,0 +1,15 @@ +# Copyright (C) 2020 by Thomas Lindner +# +# SPDX-License-Identifier: 0BSD + +from fastapi import status + + +def test_hoods_unauthorized(client): + response = client.get('/api/admin/hoods/') + assert response.status_code == status.HTTP_401_UNAUTHORIZED + + +def test_hoods_success(client, auth_header): + response = client.get('/api/admin/hoods/', headers=auth_header) + assert response.status_code == status.HTTP_200_OK diff --git a/tests/test_api_hoods.py b/tests/test_api_hoods.py new file mode 100644 index 0000000..75ac065 --- /dev/null +++ b/tests/test_api_hoods.py @@ -0,0 +1,81 @@ +# Copyright (C) 2020 by Christian +# Copyright (C) 2020 by Thomas Lindner +# +# SPDX-License-Identifier: 0BSD + +from fastapi import status + + +def test_hood_read_all(client): + response = client.get('/api/hoods/') + assert response.status_code == status.HTTP_200_OK + + +def test_hood_create_unauthorized(client, hood_id): + response = client.post('/api/hoods/') + assert response.status_code == status.HTTP_401_UNAUTHORIZED + + +def test_hood_read_unauthorized(client, hood_id): + response = client.get('/api/hoods/%d' % hood_id) + assert response.status_code == status.HTTP_401_UNAUTHORIZED + + +def test_hood_update_unauthorized(client, hood_id): + response = client.put('/api/hoods/%d' % hood_id) + assert response.status_code == status.HTTP_401_UNAUTHORIZED + + +def test_hood_delete_unauthorized(client, hood_id): + response = client.delete('/api/hoods/%d' % hood_id) + assert response.status_code == status.HTTP_401_UNAUTHORIZED + + +def test_trigger_read_all_unauthorized(client, hood_id): + response = client.get('/api/hoods/%d/triggers/' % hood_id) + assert response.status_code == status.HTTP_401_UNAUTHORIZED + + +def test_trigger_create_unauthorized(client, hood_id): + response = client.post('/api/hoods/%d/triggers/' % hood_id) + assert response.status_code == status.HTTP_401_UNAUTHORIZED + + +def test_trigger_read_unauthorized(client, hood_id, trigger_id): + response = client.get('/api/hoods/%d/triggers/%d' % (hood_id, trigger_id)) + assert response.status_code == status.HTTP_401_UNAUTHORIZED + + +def test_trigger_update_unauthorized(client, hood_id, trigger_id): + response = client.put('/api/hoods/%d/triggers/%d' % (hood_id, trigger_id)) + assert response.status_code == status.HTTP_401_UNAUTHORIZED + + +def test_trigger_delete_unauthorized(client, hood_id, trigger_id): + response = client.delete('/api/hoods/%d/triggers/%d' % (hood_id, trigger_id)) + assert response.status_code == status.HTTP_401_UNAUTHORIZED + + +def test_badword_read_all_unauthorized(client, hood_id): + response = client.get('/api/hoods/%d/badwords/' % hood_id) + assert response.status_code == status.HTTP_401_UNAUTHORIZED + + +def test_badword_create_unauthorized(client, hood_id): + response = client.post('/api/hoods/%d/badwords/' % hood_id) + assert response.status_code == status.HTTP_401_UNAUTHORIZED + + +def test_badword_read_unauthorized(client, hood_id, badword_id): + response = client.get('/api/hoods/%d/badwords/%d' % (hood_id, badword_id)) + assert response.status_code == status.HTTP_401_UNAUTHORIZED + + +def test_badword_update_unauthorized(client, hood_id, badword_id): + response = client.put('/api/hoods/%d/badwords/%d' % (hood_id, badword_id)) + assert response.status_code == status.HTTP_401_UNAUTHORIZED + + +def test_badword_delete_unauthorized(client, hood_id, badword_id): + response = client.delete('/api/hoods/%d/badwords/%d' % (hood_id, badword_id)) + assert response.status_code == status.HTTP_401_UNAUTHORIZED diff --git a/tests/test_api_test.py b/tests/test_api_test.py new file mode 100644 index 0000000..aa754c0 --- /dev/null +++ b/tests/test_api_test.py @@ -0,0 +1,36 @@ +# Copyright (C) 2020 by Christian +# Copyright (C) 2020 by Thomas Lindner +# +# SPDX-License-Identifier: 0BSD + +from fastapi import status + + +def test_test_read_all_unauthorized(client, hood_id): + response = client.get('/api/hoods/%d/test/' % hood_id) + assert response.status_code == status.HTTP_401_UNAUTHORIZED + + +def test_test_create_unauthorized(client, hood_id): + response = client.post('/api/hoods/%d/test/' % hood_id) + assert response.status_code == status.HTTP_401_UNAUTHORIZED + + +def test_test_read_unauthorized(client, hood_id, test_id): + response = client.get('/api/hoods/%d/test/%d' % (hood_id, test_id)) + assert response.status_code == status.HTTP_401_UNAUTHORIZED + + +def test_test_delete_unauthorized(client, hood_id, test_id): + response = client.delete('/api/hoods/%d/test/%d' % (hood_id, test_id)) + assert response.status_code == status.HTTP_401_UNAUTHORIZED + + +def test_test_message_read_all_unauthorized(client, hood_id, test_id): + response = client.get('/api/hoods/%d/test/%d/messages/' % (hood_id, test_id)) + assert response.status_code == status.HTTP_401_UNAUTHORIZED + + +def test_test_message_create_unauthorized(client, hood_id, test_id): + response = client.post('/api/hoods/%d/test/%d/messages/' % (hood_id, test_id)) + assert response.status_code == status.HTTP_401_UNAUTHORIZED diff --git a/tests/unit/test_api_hoods.py b/tests/unit/test_api_hoods.py deleted file mode 100644 index 2b13201..0000000 --- a/tests/unit/test_api_hoods.py +++ /dev/null @@ -1,120 +0,0 @@ -from fastapi import FastAPI, status -from fastapi.testclient import TestClient -from kibicara.model import Mapping -from kibicara.webapi import router - - -app = FastAPI() -app.include_router(router, prefix='/api') -client = TestClient(app) -Mapping.create_all() - - -def test_hood_read_all(): - response = client.get('/api/hoods/') - assert response.status_code == status.HTTP_200_OK - - -def test_hood_create_unauthorized(): - response = client.post('/api/hoods/') - assert response.status_code == status.HTTP_401_UNAUTHORIZED - - -def test_hood_read_unauthorized(): - response = client.get('/api/hoods/{hood_id}') - assert response.status_code == status.HTTP_401_UNAUTHORIZED - - -def test_hood_update_unauthorized(): - response = client.put('/api/hoods/{hood_id}') - assert response.status_code == status.HTTP_401_UNAUTHORIZED - - -def test_hood_delete_unauthorized(): - response = client.delete('/api/hoods/{hood_id}') - assert response.status_code == status.HTTP_401_UNAUTHORIZED - - -def test_trigger_read_all_unauthorized(): - response = client.get('/api/hoods/{hood_id}/triggers/') - assert response.status_code == status.HTTP_401_UNAUTHORIZED - - -def test_trigger_create_unauthorized(): - response = client.post('/api/hoods/{hood_id}/triggers/') - assert response.status_code == status.HTTP_401_UNAUTHORIZED - - -def test_trigger_read_unauthorized(): - response = client.get('/api/hoods/{hood_id}/triggers/') - assert response.status_code == status.HTTP_401_UNAUTHORIZED - - -def test_trigger_read_all_unauthorized(): - response = client.get('/api/hoods/{hood_id}/triggers/{trigger_id}') - assert response.status_code == status.HTTP_401_UNAUTHORIZED - - -def test_trigger_update_unauthorized(): - response = client.put('/api/hoods/{hood_id}/triggers/{trigger_id}') - assert response.status_code == status.HTTP_401_UNAUTHORIZED - - -def test_trigger_delete_unauthorized(): - response = client.delete('/api/hoods/{hood_id}/triggers/{trigger_id}') - assert response.status_code == status.HTTP_401_UNAUTHORIZED - - -def test_badword_read_all_unauthorized(): - response = client.get('/api/hoods/{hood_id}/badwords/') - assert response.status_code == status.HTTP_401_UNAUTHORIZED - - -def test_badword_create_unauthorized(): - response = client.post('/api/hoods/{hood_id}/badwords/') - assert response.status_code == status.HTTP_401_UNAUTHORIZED - - -def test_badword_read_unauthorized(): - response = client.get('/api/hoods/{hood_id}/badwords/{badword_id}') - assert response.status_code == status.HTTP_401_UNAUTHORIZED - - -def test_badword_update_unauthorized(): - response = client.put('/api/hoods/{hood_id}/badwords/{badword_id}') - assert response.status_code == status.HTTP_401_UNAUTHORIZED - - -def test_badword_delete_unauthorized(): - response = client.delete('/api/hoods/{hood_id}/badwords/{badword_id}') - assert response.status_code == status.HTTP_401_UNAUTHORIZED - - -def test_test_read_all_unauthorized(): - response = client.get('/api/hoods/{hood_id}/test/') - assert response.status_code == status.HTTP_401_UNAUTHORIZED - - -def test_test_create_unauthorized(): - response = client.post('/api/hoods/{hood_id}/test/') - assert response.status_code == status.HTTP_401_UNAUTHORIZED - - -def test_test_read_unauthorized(): - response = client.get('/api/hoods/{hood_id}/test/{test_id}') - assert response.status_code == status.HTTP_401_UNAUTHORIZED - - -def test_test_delete_unauthorized(): - response = client.delete('/api/hoods/{hood_id}/test/{test_id}') - assert response.status_code == status.HTTP_401_UNAUTHORIZED - - -def test_test_message_read_all_unauthorized(): - response = client.get('/api/hoods/{hood_id}/test/{test_id}/messages/') - assert response.status_code == status.HTTP_401_UNAUTHORIZED - - -def test_test_message_create_unauthorized(): - response = client.post('/api/hoods/{hood_id}/test/{test_id}/messages/') - assert response.status_code == status.HTTP_401_UNAUTHORIZED diff --git a/tests/unit/test_api_register.py b/tests/unit/test_api_register.py deleted file mode 100644 index 25be547..0000000 --- a/tests/unit/test_api_register.py +++ /dev/null @@ -1,15 +0,0 @@ -from fastapi import FastAPI, status -from fastapi.testclient import TestClient -from kibicara.model import Mapping -from kibicara.webapi import router - - -app = FastAPI() -app.include_router(router, prefix='/api') -client = TestClient(app) -Mapping.create_all() - - -def test_register_missing_body(): - response = client.post('/api/admin/register/') - assert response.status_code == status.HTTP_422_UNPROCESSABLE_ENTITY