Add Mastodon bot to Ticketfrei 3 #2

missytake · 2022-03-01T17:40:55Z

missytake commented

2022-03-01 17:40:55 +00:00

Create push & poll flows
Create DB model
Create web routes to create and delete accounts
Generate openAPI routes
Design angular components for the frontend
Test the backend flow
Write test for the API

Anything missing?

Feedback welcome :)

- [x] Create push & poll flows - [x] Create DB model - [x] Create web routes to create and delete accounts - [x] Generate openAPI routes - [x] Design angular components for the frontend - [x] Test the backend flow - [x] Write test for the API Anything missing? Feedback welcome :)

missytake added 3 commits 2022-03-01 17:40:56 +00:00

[mastodon] First approach to a mastodon bot 92e17773a8

[mastodon] Changed MastodonAccount column: instance_id -> instance 1b5e8346ed

[mastodon] Some web routes to add a Mastodon Account to Ticketfrei 75d809144e

missytake added 1 commit 2022-03-01 21:20:35 +00:00

[mastodon] Added a TODO flair f4ba7d2e40

missytake added 1 commit 2022-03-02 19:43:27 +00:00

[mastodon] Import mastodon API correctly 541792718d

missytake added 1 commit 2022-03-03 19:09:39 +00:00

[mastodon] Load database references b03286823e

missytake added 1 commit 2022-03-04 17:16:40 +00:00

[mastodon] Working now: toot reports from mastodon, but only when the next report arrives 4d105676c2

missytake force-pushed mastodon from 4d105676c2 to f66375cd77

2022-03-05 22:23:40 +00:00

Compare

missytake force-pushed mastodon from f66375cd77 to 48b177d51e

2022-03-06 09:28:05 +00:00

Compare

missytake added 1 commit 2022-03-06 09:55:29 +00:00

Revert "[doc] Document how to disable strict CORS checking" beb134972a

This reverts commit bd17d5321b.

missytake added 9 commits 2023-03-18 12:52:34 +00:00

[doc] Document how to disable strict CORS checking 217cd55609

[mastodon] First approach to a mastodon bot 2ac7574adb

[mastodon] Changed MastodonAccount column: instance_id -> instance 88ec56f154

[mastodon] Some web routes to add a Mastodon Account to Ticketfrei 208ae63e6c

[mastodon] Added a TODO flair f817e70bb5

[mastodon] Import mastodon API correctly 103ffe3e80

[mastodon] Load database references ba826acc93

[mastodon] Working now: toot reports from mastodon, but only when the next report arrives 58c720d933

Revert "[doc] Document how to disable strict CORS checking" bcc3f442ed

This reverts commit bd17d5321b.

missytake force-pushed mastodon from bcc3f442ed to d72a23781d

2023-03-18 16:30:34 +00:00

Compare

missytake added 2 commits 2023-03-18 16:41:41 +00:00

[mastodon] Moved mastodon module to new backend directory 0cfeb06908

[mastodon] Generated openAPI routes for frontend 5b7222db8d

missytake added 4 commits 2023-03-18 20:25:16 +00:00

[doc] Add documentation to update angular and openapi-generator code 1d9375c02a

[misc] Added pytest and pytest-aiohttp to test dependencies b312d11a3f

[mastodon] New style: double quotes instead of single quotes 80a5e59e97

[mastodon] Change mastodon_create to accept json instead of URL parameters 3114faedb8

missytake added 2 commits 2023-03-18 21:01:20 +00:00

[mastodon] Return 422 error for invalid input when creating mastodon bot 3f68b65e17

[tests] Testing the mastodon_create API endpoint 59dce0ebf6

juergen added 2 commits 2023-03-19 00:53:48 +00:00

[frontend] Fix openapi-generator run for mastodon f05c43ff59

[mastodon] Fix locking issue with synchronous Mastodon.py and replace last_seen with notification_dismiss c7062b3bcd

missytake reviewed 2023-03-19 10:36:06 +00:00

backend/src/kibicara/platforms/mastodon/bot.py

					
				@ -0,0 +78,4 @@

				                    await self.publish(Message(text))

				                await get_event_loop().run_in_executor(

				                    None, self.account.notifications_dismiss, status["id"]

				                )

missytake commented

2023-03-19 10:36:06 +00:00

I like dismissing old notifications on the platform instead of keeping track of last_seen ourselves, but we didn't do this in ticketfrei2, so we need to dismiss all the past notifications during the migration.

I like dismissing old notifications on the platform instead of keeping track of `last_seen` ourselves, but we didn't do this in ticketfrei2, so we need to dismiss all the past notifications during the migration.

missytake reviewed 2023-03-19 10:43:34 +00:00

backend/src/kibicara/platforms/mastodon/bot.py

					
				@ -0,0 +79,4 @@

				                await get_event_loop().run_in_executor(

				                    None, self.account.notifications_dismiss, status["id"]

				                )

				            await sleep(self.polling_interval_sec)

missytake commented

2023-03-19 10:43:34 +00:00

This is for rate limiting, I assume? We could maybe make this a bit more dynamic.

https://mastodonpy.readthedocs.io/en/stable/01_general.html#rate-limiting mentions that the default is 300 requests in 5 minutes, that would allow polling once per second instead of once per minute. But we don't know in advance how often we're gonna post, and the rate limit can be non-default.

Using the pace rate limit option is probably not possible with async? What we could use instead is the throw option to throw a MastodonRateLimitError if we run against the rate limit, request https://mastodonpy.readthedocs.io/en/stable/01_general.html#rate-limiting, and decide upon that for how long we do an await sleep().

This is for rate limiting, I assume? We could maybe make this a bit more dynamic. https://mastodonpy.readthedocs.io/en/stable/01_general.html#rate-limiting mentions that the default is 300 requests in 5 minutes, that would allow polling once per second instead of once per minute. But we don't know in advance how often we're gonna post, and the rate limit can be non-default. Using the `pace` rate limit option is probably not possible with async? What we could use instead is the `throw` option to throw a `MastodonRateLimitError` if we run against the rate limit, request https://mastodonpy.readthedocs.io/en/stable/01_general.html#rate-limiting, and decide upon that for how long we do an `await sleep()`.

missytake commented

2023-03-19 10:45:05 +00:00

Or even better, use https://mastodonpy.readthedocs.io/en/stable/01_general.html#mastodon.Mastodon.ratelimit_remaining and https://mastodonpy.readthedocs.io/en/stable/01_general.html#mastodon.Mastodon.ratelimit_reset to guess how long we should sleep between requests, and if we hit a MastodonRateLimitError, we wait until https://mastodonpy.readthedocs.io/en/stable/01_general.html#mastodon.Mastodon.ratelimit_reset.

Or even better, use https://mastodonpy.readthedocs.io/en/stable/01_general.html#mastodon.Mastodon.ratelimit_remaining and https://mastodonpy.readthedocs.io/en/stable/01_general.html#mastodon.Mastodon.ratelimit_reset to guess how long we should sleep between requests, and if we hit a `MastodonRateLimitError`, we wait until https://mastodonpy.readthedocs.io/en/stable/01_general.html#mastodon.Mastodon.ratelimit_reset.

missytake added 1 commit 2023-03-19 11:40:14 +00:00

[mastodon] Fix tests 40b62d9243

missytake added 1 commit 2023-03-19 12:24:55 +00:00

[mastodon] Remove redundant error class 1a639548f0

missytake added 1 commit 2023-03-19 12:48:03 +00:00

[tests] Test mastodon_delete route 1bee3a8042

missytake added 4 commits 2023-03-19 13:49:30 +00:00

[tests] Replace single quotes with double quotes 6dca39cdfb

[tests] Test mastodon_read route 9bb09d4e9d

[mastodon] Return instance name in read_public API 89191ac606

[mastodon] Deprecate GET mastodon route 5d9f7cbe63

missytake added 1 commit 2023-03-19 16:27:14 +00:00

[tests] Make Mastodon tests a bit more readable f97e041284

juergen added 3 commits 2023-03-19 17:30:51 +00:00

[frontend] Regenerate openapi for frontend due to mastodon API changes 96e6340ef3

[mastodon] Fix delete endpoint for mastodon 68bbd358a5

[frontend] Add initial mastodon frontend a6c0b9c962

missytake force-pushed mastodon from a6c0b9c962 to ec0abb5e24

2023-03-19 17:55:00 +00:00

Compare

missytake changed title from ~~WIP: add Mastodon bot to Ticketfrei 3~~ to Add Mastodon bot to Ticketfrei 3

2023-03-19 18:01:00 +00:00

missytake reviewed 2023-03-19 18:05:19 +00:00

frontend/src/app/core/api/.openapi-generator/FILES

					
				@ -16,9 +17,10 @@ git_push.sh

				index.ts

				model/bodyAccessToken.ts

				model/bodyAdmin.ts

				model/bodyAdminLoginAdminLoginPost.ts