Add Mastodon bot to Ticketfrei 3 #2

missytake · 2022-03-01T17:40:55Z

missytake commented

2022-03-01 17:40:55 +00:00

Create push & poll flows
Create DB model
Create web routes to create and delete accounts
Generate openAPI routes
Design angular components for the frontend
Test the backend flow
Write test for the API

Anything missing?

Feedback welcome :)

- [x] Create push & poll flows - [x] Create DB model - [x] Create web routes to create and delete accounts - [x] Generate openAPI routes - [x] Design angular components for the frontend - [x] Test the backend flow - [x] Write test for the API Anything missing? Feedback welcome :)

missytake added 3 commits 2022-03-01 17:40:56 +00:00

92e17773a8 [mastodon] First approach to a mastodon bot

1b5e8346ed [mastodon] Changed MastodonAccount column: instance_id -> instance

75d809144e [mastodon] Some web routes to add a Mastodon Account to Ticketfrei

missytake added 1 commit 2022-03-01 21:20:35 +00:00

f4ba7d2e40 [mastodon] Added a TODO flair

missytake added 1 commit 2022-03-02 19:43:27 +00:00

541792718d [mastodon] Import mastodon API correctly

missytake added 1 commit 2022-03-03 19:09:39 +00:00

b03286823e [mastodon] Load database references

missytake added 1 commit 2022-03-04 17:16:40 +00:00

4d105676c2 [mastodon] Working now: toot reports from mastodon, but only when the next report arrives

missytake force-pushed mastodon from 4d105676c2 to f66375cd77

2022-03-05 22:23:40 +00:00

Compare

missytake force-pushed mastodon from f66375cd77 to 48b177d51e

2022-03-06 09:28:05 +00:00

Compare

missytake added 1 commit 2022-03-06 09:55:29 +00:00

beb134972a Revert "[doc] Document how to disable strict CORS checking"

This reverts commit bd17d5321b.

missytake added 9 commits 2023-03-18 12:52:34 +00:00

217cd55609 [doc] Document how to disable strict CORS checking

2ac7574adb [mastodon] First approach to a mastodon bot

88ec56f154 [mastodon] Changed MastodonAccount column: instance_id -> instance

208ae63e6c [mastodon] Some web routes to add a Mastodon Account to Ticketfrei

f817e70bb5 [mastodon] Added a TODO flair

103ffe3e80 [mastodon] Import mastodon API correctly

ba826acc93 [mastodon] Load database references

58c720d933 [mastodon] Working now: toot reports from mastodon, but only when the next report arrives

bcc3f442ed Revert "[doc] Document how to disable strict CORS checking"

This reverts commit bd17d5321b.

missytake force-pushed mastodon from bcc3f442ed to d72a23781d

2023-03-18 16:30:34 +00:00

Compare

missytake added 2 commits 2023-03-18 16:41:41 +00:00

0cfeb06908 [mastodon] Moved mastodon module to new backend directory

5b7222db8d [mastodon] Generated openAPI routes for frontend

missytake added 4 commits 2023-03-18 20:25:16 +00:00

1d9375c02a [doc] Add documentation to update angular and openapi-generator code

b312d11a3f [misc] Added pytest and pytest-aiohttp to test dependencies

80a5e59e97 [mastodon] New style: double quotes instead of single quotes

3114faedb8 [mastodon] Change mastodon_create to accept json instead of URL parameters

missytake added 2 commits 2023-03-18 21:01:20 +00:00

3f68b65e17 [mastodon] Return 422 error for invalid input when creating mastodon bot

59dce0ebf6 [tests] Testing the mastodon_create API endpoint

juergen added 2 commits 2023-03-19 00:53:48 +00:00

f05c43ff59 [frontend] Fix openapi-generator run for mastodon

c7062b3bcd [mastodon] Fix locking issue with synchronous Mastodon.py and replace last_seen with notification_dismiss

missytake reviewed 2023-03-19 10:36:06 +00:00

backend/src/kibicara/platforms/mastodon/bot.py

													
				@ -0,0 +78,4 @@

				                    await self.publish(Message(text))

				                await get_event_loop().run_in_executor(

				                    None, self.account.notifications_dismiss, status["id"]

				                )

missytake commented

2023-03-19 10:36:06 +00:00

Poster

I like dismissing old notifications on the platform instead of keeping track of last_seen ourselves, but we didn't do this in ticketfrei2, so we need to dismiss all the past notifications during the migration.

I like dismissing old notifications on the platform instead of keeping track of `last_seen` ourselves, but we didn't do this in ticketfrei2, so we need to dismiss all the past notifications during the migration.

missytake reviewed 2023-03-19 10:43:34 +00:00

backend/src/kibicara/platforms/mastodon/bot.py

													
				@ -0,0 +79,4 @@

				                await get_event_loop().run_in_executor(

				                    None, self.account.notifications_dismiss, status["id"]

				                )

				            await sleep(self.polling_interval_sec)

missytake commented

2023-03-19 10:43:34 +00:00

Poster

This is for rate limiting, I assume? We could maybe make this a bit more dynamic.

https://mastodonpy.readthedocs.io/en/stable/01_general.html#rate-limiting mentions that the default is 300 requests in 5 minutes, that would allow polling once per second instead of once per minute. But we don't know in advance how often we're gonna post, and the rate limit can be non-default.

Using the pace rate limit option is probably not possible with async? What we could use instead is the throw option to throw a MastodonRateLimitError if we run against the rate limit, request https://mastodonpy.readthedocs.io/en/stable/01_general.html#rate-limiting, and decide upon that for how long we do an await sleep().

This is for rate limiting, I assume? We could maybe make this a bit more dynamic. https://mastodonpy.readthedocs.io/en/stable/01_general.html#rate-limiting mentions that the default is 300 requests in 5 minutes, that would allow polling once per second instead of once per minute. But we don't know in advance how often we're gonna post, and the rate limit can be non-default. Using the `pace` rate limit option is probably not possible with async? What we could use instead is the `throw` option to throw a `MastodonRateLimitError` if we run against the rate limit, request https://mastodonpy.readthedocs.io/en/stable/01_general.html#rate-limiting, and decide upon that for how long we do an `await sleep()`.

missytake commented

2023-03-19 10:45:05 +00:00

Poster

Or even better, use https://mastodonpy.readthedocs.io/en/stable/01_general.html#mastodon.Mastodon.ratelimit_remaining and https://mastodonpy.readthedocs.io/en/stable/01_general.html#mastodon.Mastodon.ratelimit_reset to guess how long we should sleep between requests, and if we hit a MastodonRateLimitError, we wait until https://mastodonpy.readthedocs.io/en/stable/01_general.html#mastodon.Mastodon.ratelimit_reset.

Or even better, use https://mastodonpy.readthedocs.io/en/stable/01_general.html#mastodon.Mastodon.ratelimit_remaining and https://mastodonpy.readthedocs.io/en/stable/01_general.html#mastodon.Mastodon.ratelimit_reset to guess how long we should sleep between requests, and if we hit a `MastodonRateLimitError`, we wait until https://mastodonpy.readthedocs.io/en/stable/01_general.html#mastodon.Mastodon.ratelimit_reset.

missytake added 1 commit 2023-03-19 11:40:14 +00:00

40b62d9243 [mastodon] Fix tests

missytake added 1 commit 2023-03-19 12:24:55 +00:00

1a639548f0 [mastodon] Remove redundant error class

missytake added 1 commit 2023-03-19 12:48:03 +00:00

1bee3a8042 [tests] Test mastodon_delete route

missytake added 4 commits 2023-03-19 13:49:30 +00:00

6dca39cdfb [tests] Replace single quotes with double quotes

9bb09d4e9d [tests] Test mastodon_read route

89191ac606 [mastodon] Return instance name in read_public API

5d9f7cbe63 [mastodon] Deprecate GET mastodon route

missytake added 1 commit 2023-03-19 16:27:14 +00:00

f97e041284 [tests] Make Mastodon tests a bit more readable

juergen added 3 commits 2023-03-19 17:30:51 +00:00

96e6340ef3 [frontend] Regenerate openapi for frontend due to mastodon API changes

68bbd358a5 [mastodon] Fix delete endpoint for mastodon

a6c0b9c962 [frontend] Add initial mastodon frontend

missytake force-pushed mastodon from a6c0b9c962 to ec0abb5e24

2023-03-19 17:55:00 +00:00

Compare

missytake changed title from ~~WIP: add Mastodon bot to Ticketfrei 3~~ to Add Mastodon bot to Ticketfrei 3

2023-03-19 18:01:00 +00:00

missytake reviewed 2023-03-19 18:05:19 +00:00

frontend/src/app/core/api/.openapi-generator/FILES

													
				@ -16,9 +17,10 @@ git_push.sh

				index.ts

				model/bodyAccessToken.ts

				model/bodyAdmin.ts

				model/bodyAdminLoginAdminLoginPost.ts